Bladeren bron

Fix swapped test in compute_header_length (1d4241dff)

Stéphane Raimbault 14 jaren geleden
bovenliggende
commit
ef3e8740fc
1 gewijzigde bestanden met toevoegingen van 3 en 5 verwijderingen
  1. 3 5
      src/modbus.c

+ 3 - 5
src/modbus.c

@@ -500,22 +500,20 @@ static uint8_t compute_header_length(int function, msg_type_t msg_type)
 {
 {
     int length;
     int length;
 
 
-    if (msg_type == MSG_INDICATION) {
+    if (msg_type == MSG_CONFIRMATION) {
         if (function == FC_REPORT_SLAVE_ID) {
         if (function == FC_REPORT_SLAVE_ID) {
-            length = 0;
+            length = 1;
         } else {
         } else {
             /* Should never happen, the other header lengths are precomputed */
             /* Should never happen, the other header lengths are precomputed */
             abort();
             abort();
         }
         }
-    } else /* MSG_CONFIRMATION */ {
+    } else /* MSG_INDICATION */ {
         if (function <= FC_WRITE_SINGLE_COIL ||
         if (function <= FC_WRITE_SINGLE_COIL ||
             function == FC_WRITE_SINGLE_REGISTER) {
             function == FC_WRITE_SINGLE_REGISTER) {
             length = 4;
             length = 4;
         } else if (function == FC_WRITE_MULTIPLE_COILS ||
         } else if (function == FC_WRITE_MULTIPLE_COILS ||
                    function == FC_WRITE_MULTIPLE_REGISTERS) {
                    function == FC_WRITE_MULTIPLE_REGISTERS) {
             length = 5;
             length = 5;
-        } else if (function == FC_REPORT_SLAVE_ID) {
-            length = 1;
         } else if (function == FC_READ_AND_WRITE_REGISTERS) {
         } else if (function == FC_READ_AND_WRITE_REGISTERS) {
             length = 9;
             length = 9;
         } else {
         } else {