Преглед на файлове

Fix my so stupid fix for VD-1301 vulnerability

I can't believe I committed that copy/paste mistake.
Sorry Maor Vermucht and Or Peles, excepted naming your original
patch was OK.

Thank you Karl Palsson for your review.
Stéphane Raimbault преди 5 години
родител
ревизия
6f915d4215
променени са 1 файла, в които са добавени 1 реда и са изтрити 1 реда
  1. 1 1
      src/modbus.c

+ 1 - 1
src/modbus.c

@@ -874,7 +874,7 @@ int modbus_reply(modbus_t *ctx, const uint8_t *req,
         int nb_bytes = req[offset + 5];
         int mapping_address = address - mb_mapping->start_registers;
 
-        if (nb < 1 || MODBUS_MAX_WRITE_REGISTERS < nb || nb_bytes * 8 < nb) {
+        if (nb < 1 || MODBUS_MAX_WRITE_REGISTERS < nb || nb_bytes != nb * 2) {
             rsp_length = response_exception(
                 ctx, &sft, MODBUS_EXCEPTION_ILLEGAL_DATA_VALUE, rsp, TRUE,
                 "Illegal number of values %d in write_registers (max %d)\n",